[naviserver-devel] new vfs changes 2

[Zoran V. <zv...@ar...>]

Hi!

Stephen, I see you did checkout those. I wonder how you found all those
minor signedness problems? I am always compiling with -Wall and compiler
did not tell me anything, i.e. the compilation went 100% clean?

Also, please look in the modload.c about creating new interp before  
Tcl_FSLoad.
I deliberately used Tcl_CreateInterp and not Ns_TclAllocateInterp
because of the speed. At that point, the interp is really only needed  
for
error reporting. I even wanted to change Tcl calls to accept NULL  
instead
but this was too much changes and I did not want to argue about that  
on the
Tcl core list. Hence, I took the least cost path.
Also: watch: there is a Tcl_DeleteInterp() call too much left there. I
suggest (if you do not have any other reason) to go back to  
Tcl_CreateInterp.
This will save us cycles at that point and we'll loose nothing.

And, I see that the VFS changes did not broke anythig (well, apart  
from that
DVS stuff and MIN/MAX) all went fine, or?

Cheers
Zoran