[naviserver-devel] Re: [naviserver-commits] naviserver/include ns.h,1.27,1.28

[Stephen D. <sd...@gm...>]

On 6/28/05, Vlad Seryakov <ser...@us...> wrote:
> Update of /cvsroot/naviserver/naviserver/include
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3191/include
>=20
> Modified Files:
>         ns.h
> Log Message:
> Added Ns_ConnVSetHeaders function to add headers to the output in printf-=
style way
> Added support for Range: header for returning partial content
>=20
>=20
> Index: ns.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/naviserver/naviserver/include/ns.h,v
> retrieving revision 1.27
> retrieving revision 1.28
> diff -C2 -d -r1.27 -r1.28
> *** ns.h        13 Jun 2005 06:14:26 -0000      1.27
> --- ns.h        28 Jun 2005 20:15:43 -0000      1.28
> ***************
> *** 1014,1017 ****
> --- 1014,1018 ----
>   NS_EXTERN int Ns_ConnFlushHeaders(Ns_Conn *conn, int status);
>   NS_EXTERN void Ns_ConnSetHeaders(Ns_Conn *conn, char *field, char *valu=
e);
> + NS_EXTERN void Ns_ConnVSetHeaders(Ns_Conn *conn, char *field, char *fmt=
,...);
>   NS_EXTERN void Ns_ConnCondSetHeaders(Ns_Conn *conn, char *field, char *=
value);
>   NS_EXTERN void Ns_ConnReplaceHeaders(Ns_Conn *conn, Ns_Set *newheaders)=
;


The 'V' in Ns_ConnVSetHeaders() suggests it takes a va_list, as in
Ns_DStringVPrintf() used in the implementation.

Unfortunately, Ns_ConnPrintfHeader() already exists.  It prints
directly to the output stream which looks pretty silly.  The function
is unused.

How about we rename your function Ns_ConnPrintfHeaders and drop
Ns_ConnPrintfHeader?  Does anyone think that will be a problem?