Re: [naviserver-devel] v4.99.23 Tests failing building on Debian Buster Pt1: encoding_ns_http-1.1

[Gustaf N. <ne...@wu...>]

There are now two changes committed to bitbucket:

a) Provide an error message when the configured locale is not installed 
on the host (misconfiguration)

This change causes NaviServer to abort, when the configured locale is 
not installed on the host. Typically, this locale is e.g. used by 
ns_strcoll for determining the default collating order. The 
configuration file for the regression testing sets the environment 
variable LANG to "en_US.UTF-8". This means that for running the stock
regression test, this locale must be installed on the OS level.

b) Silence warning with recent versions of gcc when certain values of 
_FORTIFY_SOURCE/-Wstringop-overflow are set

Newer versions of gcc support warning of dangerous operations (such as 
e.g. strncat) when these depend on not easy traceable sources. In the 
fixed case, the warning was:

    warning: ‘__builtin_strncat’ specified bound depends on
    the length of the source argument

With FORTIFY_SOURCE whenever possible, GCC tries to use buffer-length 
aware replacements for functions, which was not possible in the case in 
question. The documentation says that with _FORTIFY_SOURCE set to
2, some more checking is added, but some conforming programs might fail.

The case for (b) was a false positive, but it is still better to silence 
these rather than ignoring it.

all the best

-g