Re: [naviserver-devel] ns_striphtml test failures?

[Gustaf N. <ne...@wu...>]

On 16.01.19 20:39, Andrew Piskorski wrote:
> I built the latest NaviServer head from source (on Linux, Ubuntu
> 16.04.2 LTS), and "make test" is reporting 8 failures, all with
> ns_striphtml.  Is this a known problem, or do I have something broken?

Just a quick feedback: it is not a known problem, i don't see this on 
our systems
(checked quickly with Debian sid and macOS). The version i am testing is two
(unrelated) commits ahead of yours, but there is no relation in these 
commits.

You have on the system an older Tcl version (8.6.5), but i would be 
surprised,
if this makes a difference. Debian sid is the bleeding edge Debian, so this
has newer compilers etc., maybe one has to add for older gccs 
"-finput-charset"
or setting "LANG=en_US.UTF-8" before compiling. If this is the case, one 
has to
replace the utf-8 strings in tclmisc.c to backslash sequences.

If the above sheds no light, I'll try to test with Tcl 8.6.5 and
Ubuntu 16.04.2 the next days.

all the best

-g
PS: The log message about <NULL> is a false warning, i've removed it 
already.

================================================================
% make test TESTFLAGS="-verbose start -file ns_striphtml.test"
...
[15/Jan/2019:20:07:13][5226.7fe5a5153740][-main-] Notice: nsmain: NaviServer/4.99.17 (49c314f2b1e9+ default tip) starting
...
[15/Jan/2019:20:07:13][5226.7fe5a5153740][-main-] Notice: nsmain: Tcl version: 8.6.9
...
Only running test files that match:  ns_striphtml.test
Tests began at Tue Jan 15 20:07:13 CET 2019
ns_striphtml.test
---- ns_striphtml-1.0 start
---- ns_striphtml-2.0.1 start
---- ns_striphtml-2.0.2 start
---- ns_striphtml-2.0.3 start
---- ns_striphtml-2.1 start
---- ns_striphtml-2.2 start
---- ns_striphtml-2.2b start
---- ns_striphtml-2.3 start
---- ns_striphtml-2.3b start
---- ns_striphtml-2.4 start
---- ns_striphtml-2.4b start
---- ns_striphtml-3.0 start
[15/Jan/2019:20:07:13][5226.7fe597ecb700][-command-] Notice: name length of <NULL> incorrect, should be 4
---- ns_striphtml-4.0 start

Tests ended at Tue Jan 15 20:07:13 CET 2019
all.tcl:        Total   13      Passed  13      Skipped 0       Failed  0
Sourced 1 Test Files.
...
% env
LC_ALL=en_US.UTF-8
LANG=en_US.UTF-8


> >From the test output, it looks like the test failures are always
> because ns_striphtml is stripping MORE than it is supposed to, e.g.:
>
> ==== ns_striphtml-2.0.1 nbsp entity FAILED
> ---- Result was:
> helloworld
> ---- Result should have been (exact matching):
> hello world
> ==== ns_striphtml-2.0.1 FAILED
>
> ==== ns_striphtml-2.0.2 nbsp entity FAILED
> ---- Result was:
> helloworld
> ---- Result should have been (exact matching):
> hello<world
> ==== ns_striphtml-2.0.2 FAILED
>
> Btw, I ran the tests from shells with each of these two different LANG
> settings, but (fortunately) that seemed to make no difference, the
> same 8 tests fail the same way in both cases:
>
>    LANG=en_US.UTF-8
>    LANG=en_US.iso-8859-1
>
> I've also attached the full "make test" output file.