Re: [naviserver-devel] Towards NaviServer 4.99.17

[Gustaf N. <ne...@wu...>]

On 30.10.18 19:47, Oleg wrote:
> I tested the 32-bit Naviserver for Windows 8.1/32bit (using MSVC 2015) and Windows 10/64bit (using MSVC 2017).
> Compiling required some tricks but the testing was almost successful.
> See testing output in the attachment (buildall.ooa.test.log).
>
> Some notes.
> 1) Makefile.win32.patch - to compile nsdbtest.
> 2) nsthread.h.patch - stdint.h is needed here because of the int32_t used just below.
> 3) test.nscfg.patch - for loading .dll modules
>
> And some hacks for problems with sockets - sock.c.patch (windows returns WSAWOULDBLOCK after connect on async socket) and win32readable.patch (to avoid "premature end of data")
>
> Thank you for your work.

Great and many thanks for the tests and (very good) patches!

I have applied most of these without changes, with one exception:
In the patch "test.nscfg.patch" you changed

    .../nssock.so
(and similar) to
    .../nssock[info sharedlib]

which looks very plausible, but on some platforms (e.g. macOS) the extension
of the modules is ".so", although its [info sharedlibextension] is 
".dylib". I guess
this was to make config files more portable, and due to the fact that the
modules are not regular shared libraries in nature.

Since i am not sure, whether windows forces you to use .dll, i make a small
proc to keep the config-file fo the test server compatible with windows.
I would hate to change the extensions for modules under macOS (such
that [info sharedlibextension] wornks always, since this would break
existing installations/configurations.

A way out might be to handle this on the .c code where the libraries
are loaded (e.g. to allow module names without the extension), but
this is nothing for the current release.

Due to the fact that probably nobody was running the regression test
under windows since many year, it is great to see, that 1243 out of 1271
tests succeeded (97.8%). i have made some more changes for low
hanging gruits, such that the number should go up further.

all the best and many thanks!

-g

> Thank you for your work.
>
> Regards,
>
> Oleg.