Re: [naviserver-devel] review of Windows build changes

[Andrew P. <at...@pi...>]

On Fri, Sep 26, 2014 at 01:15:45PM +0200, Gustaf Neumann wrote:
> The change [1] should fix the windows behavior
> [1] 
> https://bitbucket.org/naviserver/naviserver/commits/b743a8847dd01704ffdcfe98cc8a95a80ad7eea1

You're right, that one line change fixed it, thanks!  Now with that
blocking bug out of the way, it looks I sill have more Windows build
failures with your recent changes.  I'll do more debugging and see why.

> Does anyone know, why we have a define for _WIN32_WINNT in 
> our sources?
> Windows should know, what version it has. Maybe a leftover?
> Andrew, can you check, what happens, if we remove it?

I tried removing the _WIN32_WINNT definition entirely just now, which
DID change the build behavior!  It switched to a different set of
errors and warnings.  So maybe we do need it, but I don't know why.
I'll look more once I get the build working again.

-- 
Andrew Piskorski <at...@pi...>