Re: [naviserver-devel] ns_info / ns_server

[Jeff R. <dv...@di...>]

Gustaf Neumann wrote:

> In naviserver, we have essentially the two commands "ns_info" and
> "ns_server" to obtain information about the "nds" process, about a
> single (virtual) server and about (connection) pools.

> I would propose to make the following changes to address these problems:

The changes you suggest are sensible, giving better overall introspection.

Does it make sense to have 2 different information-gathering commands, 
tho?  Why not consolidate all these functions into "ns_info", giving 
appropriate subcommands -server and/or -pool flags as necessary?

As for the pool subcommands, do the existing subcommands handle any new 
data points that may be available?  For example, if there were nested 
pools you would want parents and children, or if they were dynamic you 
would want to know when they were created.  Or more concretely, can they 
provide info on how many connections in the pool are being handled with 
background delivery?

> Some of the variants with the specified ?-server ...? might have
> concurrency issues, but maybe it is not necessary to support for every

I recall some comments in the past that ns_server doesn't do all the 
necessary locking and so is not particularly safe, being intended for 
occasional use on development servers rather than frequent use on 
heavily loaded servers.  That may have been about older or 
aolserver-specific code.

-J