Re: [naviserver-devel] [naviserver-commits] naviserver/nsd tclobj.c, 1.7, 1.8

[Vasiljevic Z. <zv...@ar...>]

On 12.05.2008, at 14:41, Stephen Deasey wrote:

> I was just passively-aggressively suggesting you don't run 'make test'
> enough...  :-)

I know. Huh. There must be a reason to that. And the reason is that I  
have
a "slightly" diffent build for our product which is sometimes (link- 
wise)
colliding with off-the-shelf build. In order to "make test" I first need
to remove/save /usr/local/ns, then "make install" then "make test"  
then I
need to re-activate my private state. This isn't that complex but when
you are under time-constraints (i am always under time-constraints) you
default to saving time wherever you can. The "make test" is a first
candidate most of the time...

>
>
> Also, there's no tests/ns_job.test to cover all those bugs you fixed.

There are no bugs got fixed. Rather I added new feature and while
adding it, I made some errors because of the non-transparent locking
strategy. Which I then fixed again. So the only real test that should
go there is to check the (new) script cancellation.
I will put this on the my list.

FWIW: please DO continue to bug myself and others to keep good
practices. This increases the quality of the code and I am ALL
for it.

Cheers
Zoran