[ naviserver-Bugs-1724222 ] Segfault in progress handler

[SourceForge.net <no...@so...>]

Bugs item #1724222, was opened at 2007-05-23 14:50
Message generated for change (Comment added) made by sdeasey
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=719006&aid=1724222&group_id=130646

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: naviserver - libnsd, libnsthread, nsd
>Group: Bug 
>Status: Closed
>Resolution: Fixed
Priority: 9
Private: No
Submitted By: Stephen Deasey (sdeasey)
>Assigned to: Stephen Deasey (sdeasey)
Summary: Segfault in progress handler

Initial Comment:

The upload progress handler is not virtual server safe.

It requires users to generate unique URLs.

There is an occasionl segfault:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1104157584 (LWP 9312)]
0x4010e678 in Tcl_DeleteHashEntry (entryPtr=0x41803738) at /home/sd/tcl8.4.13/unix/../generic/tclHash.c:547
547	/home/sd/tcl8.4.13/unix/../generic/tclHash.c: No such file or directory.
	in /home/sd/tcl8.4.13/unix/../generic/tclHash.c
(gdb) bt
#0  0x4010e678 in Tcl_DeleteHashEntry (entryPtr=0x41803738) at /home/sd/tcl8.4.13/unix/../generic/tclHash.c:547
#1  0x40052af5 in ResetProgress (arg=0x418037f8) at progress.c:241
#2  0x4005adab in NsSlsCleanup (sockPtr=0x41801e50) at sls.c:443
#3  0x40040f34 in SockClose (sockPtr=0x41801e50, keep=0) at driver.c:1914
#4  0x4003f9b9 in NsSockClose (sockPtr=0x41801e50, keep=0) at driver.c:896
#5  0x4003c16e in Ns_ConnClose (conn=0x987e470) at connio.c:103
#6  0x40053c0e in ConnRun (connPtr=0x987e470) at queue.c:763
#7  0x400536fd in NsConnThread (arg=0x418034e0) at queue.c:590
#8  0x4009a167 in NsThreadMain (arg=0x41803518) at thread.c:211
#9  0x4009b1fa in ThreadMain (arg=0x41803518) at pthread.c:752
#10 0x002453db in start_thread () from /lib/libpthread.so.0
#11 0x001ce26e in clone () from /lib/libc.so.6
(gdb) up 1
#1  0x40052af5 in ResetProgress (arg=0x418037f8) at progress.c:241
241	        Tcl_DeleteHashEntry(pPtr->hPtr);
(gdb) print *pPtr
$1 = {current = 0, size = 1027, hPtr = 0x41803738}
(gdb) print *pPtr->hPtr
$2 = {nextPtr = 0x20545550, tablePtr = 0x7475702f, hash = 0x54544820, clientData = 0x2e312f50, key = {oneWordValue = 0x61610031 "", 
    objPtr = 0x61610031, words = {1633746993}, string = "1\000aa"}}
(gdb) print *pPtr->hPtr->tablePtr
$3 = {buckets = 0x0, staticBuckets = {0x0, 0x0, 0x0, 0x0}, numBuckets = 0, numEntries = 0, rebuildSize = 0, downShift = 0, mask = 0, 
  keyType = 0, findProc = 0, createProc = 0, typePtr = 0x0}

----------------------------------------------------------------------

>Comment By: Stephen Deasey (sdeasey)
Date: 2007-07-31 18:26

Message:
Logged In: YES 
user_id=87254
Originator: YES

Fixed crashing:

http://naviserver.cvs.sourceforge.net/naviserver/naviserver/ChangeLog?revision=1.660&view=markup

----------------------------------------------------------------------

Comment By: Stephen Deasey (sdeasey)
Date: 2007-05-23 14:52

Message:
Logged In: YES 
user_id=87254
Originator: YES

Ideally this should be an external module, but currently there is no clean
way to hook into the spooler guts.

The spooler should be re-written to take user submitted callbacks rather
than the currently hard coded functions within nsd/driver.c.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=719006&aid=1724222&group_id=130646