From: SourceForge.net <no...@so...> - 2005-06-29 02:23:22
|
Feature Requests item #1229138, was opened at 2005-06-28 16:14 Message generated for change (Settings changed) made by seryakov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=719009&aid=1229138&group_id=130646 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: C-API Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: Vlad Seryakov (seryakov) Assigned to: Vlad Seryakov (seryakov) Summary: Range: support Initial Comment: I modified fastpath to support Range: headers in the request. Pretty simple and does not affect existing processing. ---------------------------------------------------------------------- Comment By: Zoran Vasiljevic (vasiljevic) Date: 2005-06-28 16:34 Message: Logged In: YES user_id=95086 Do not forget to update the news file since this might be interesting for people when looking-up what is different between us and AS. Also, to increase code readability, I'd make a private call which given the connection headers will return NS_OK or NS_ERROR and would place the computed offset and size in some per-ref pointers. This way it is easier to follow the code, IMO, and the parsing of Range headers does not clutter the rest (of the code). What I also think: the http result codes like 416, 206 etc should be enumerated or #define'd so it is clearer for the ocassional reader what is actually being done. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=719009&aid=1229138&group_id=130646 |