From: Frank K. <fbk...@ve...> - 2007-04-12 08:04:46
|
H. Peter Anvin wrote: > Frank Kotler wrote: > >> sp...@dy... wrote: >> >>> My modifications to NASM for general x86-64/x64/AMD64/EM64T support >>> have been uploaded to the NASM CVS at >>> http://sourceforge.net/cvs/?group_id=6208 >> >> >> Thanks, Keith! >> >>> It will probably take some time for some possible bug fixes and >>> various "official" testing before it will be considered a stable >>> release, but you can be apart of this process to help bring it out as >>> a full release by compiling the latest CVS version and testing various >>> 64-bit code against it!!! >> >> >> I'm having a bit of trouble getting it to compile (gcc 3.3.4). Deluge >> of warnings about "signedness", and error in outmacho.c on that >> "__builtin_ctzl". Commenting that out (leaving the "else") gets by that. > > > That's because instead of "#ifdef __GNUC__" it really should be > "#if __GNUC__ >= 4"; I think gcc 3.4+ might have had these functions, > but requiring gcc4 is fine for it. Okay. That works. >> Flock of errors in the "rdoff" stuff... I *think* stemming from your >> "typedef"s. I don't know how to fix it. Any ideas? >> >> Best, >> Frank >> >> In file included from rdfdump.c:11: >> rdoff.h:23: error: parse error before "uint32" >> rdoff.h:23: warning: type defaults to `int' in declaration of `uint32' >> rdoff.h:23: error: ISO C forbids data definition with no type or >> storage class > > > We really should get rid of those data types and use uint32_t et al > instead. I thought that's what Keith was doing.... (offending lines from rdoff.h) /* Type definitions */ typedef uint32_t uint32; typedef uint16_t uint16; typedef uint8_t byte; typedef unsigned int bool; The problem with this (I think everything else "cascades" from this), and the warnings throughout, make me think that gcc isn't quite gettin' what Keith's sayin'. > I also notice a lot of text strings got converted to "int8_t"; that's > probably a wart. > > Anyway, we'll get this stuff cleaned up, I'm not worried about that. > HUGE thanks to Keith for all your work! Absolutely! Best "shot in the arm" Nasm's had for some time! Best, Frank |