From: Cyrill G. <gor...@gm...> - 2009-09-19 20:10:05
|
[anonymous coward - Sat, Sep 19, 2009 at 05:17:09PM +0200] | | > Peter, the point which is obscure for me is that _how_ should we | > threat DB/DW/DD ... as signed or unsigned? I suppose both are valid | > so we have to check if value is passed is negative and then apply | > proper test on it. Right? | | DB = -127...255 | I suppose you meant [-128;255]. I find Peter's functions clean/elegant way indeed (in which I never doubt :). So here is a plan: 1) readnum() should remain the same -- ie expand number being read into 64bit value. 2) introduce three helpers Peter suggested. 3) insn_size will check for constant (ie DB/DW...) size. Sounds good? -- Cyrill |