#15 Commit e792e4 breaks build with GCC 14 and 15

[listout]

The commit [e792e4] break building with GCC 14 and 15. I had to partially revert the commit to continue building with GCC 14 and above.

First observed on Gentoo Linux with GCC 14, I reproduced with GCC 15 as
well. Please reffer: https://bugs.gentoo.org/927451.
A build log can be found at https://927451.bugs.gentoo.org/attachment.cgi?id=888069

[Jon Trulson]

I think there is a problem here...

Applying your patch simply re-introduces 4 incompatible-pointer-types warning (or errors depending on gcc options).

I think the issue is that on your system, _Xconst is not properly defined to const like it should be.

This is a problem with your X11 configuration and the ancient NAS code. On my Ubuntu 22.04 system (and others) _Xconst is properly defined as const - while on your system it is not for some reason.

I've made a patch that I hope will work on your system and mine. Please try it and let me know, and I'll merge it.

[listout]

Got almost the same error with the patch in your comment.
https://paste.gentoo.zip/oALV47cL

I think the issue is that on your system, _Xconst is not properly defined to const like it should be.

I've to check why this might be the case.

[listout]

May be related that https://gitlab.freedesktop.org/xorg/lib/libxaw/-/commit/d0fcbd9722ad691ca0b5873c98e8e9c236fa718b changed the definition of XawListChange
in <X11/Xaw/List.h> from _Xconst char * to String *, where
String is defined as const if _CONST_X_STRINGis defined.

[Petr Písař]

It is. This bug report is a duplicate of https://sourceforge.net/p/nas/bugs/14/ where I posted a fix.

[Jon Trulson]

Should be fixed in master.