Menu

#12 Correct pointer types for GCC 14

v1.0 (example)
fixed
nobody
None
5
2024-02-04
2024-02-02
No

Now that GCC 14 is available, there is a new class of compile errors because GCC 14 became more sensitive to pointer types. An attached patch fixes it.

By the way, it seems there is a memory leak at
clients/audio/audemo/audemo.c:524. makeFileList() returns a newly
allocated list of file names, the list is passed to XawListChange(),
but then the list is never freed. libXaw prescribes that a list
passed to XawListChange() is used in place and must be kept available
for the lifetime of the widget, or until the list is replaced with
XawListChange(). A probable fix is assigning the newly allocated list
to globals->fileNames after returning from XawListChange(). This patch
does not address this leak.

1 Attachments

Discussion

  • Jon Trulson

    Jon Trulson - 2024-02-04

    Thanks for the patch, I've merged it to master.

     
  • Jon Trulson

    Jon Trulson - 2024-02-04
    • status: open --> fixed
     

Log in to post a comment.