Re: [NAntC-Dev] Bugs in Perforce Nant Tasks

[Gert D. <ger...@te...>]

David,

I don't recall who originally contributed the perforce tasks (and I don't 
have the sources available right now to check).

Problem is that I don't have a perforce repository available to test 
against.

Could you review the source code of these tasks, and perhaps provide patches 
for it ?

I'll contact the orignal author and ask him to review your changes.

What do you think?

Gert

----- Original Message ----- 
From: "Weintraub, David" <dav...@bo...>
To: <nan...@li...>
Sent: Tuesday, September 19, 2006 11:54 PM
Subject: [NAntC-Dev] Bugs in Perforce Nant Tasks


>I am having trouble with some of the Nant Perforce tasks.
>
> First problem is with "p4change". I am doing this:
>
>      <property name="p4Changelist" value="test_test_test"/>
>      <p4change changelist="${p4Changelist}"
>          client="${p4Client}"
>          port="${p4Port}"
>          user="${p4User}"
>          verbose="${isDebug}"/>
>
> This is attempting to bring up a text file for me to edit which it
> shouldn't be doing in the middle of a nant build.
>
> ===============================================
> Here's the other problem.
>
> I manually create a changelist, and put in my description
> "test_test_test". Perforce numbers this changelist as 1001:
>
> Now if I do this:
>
>       <property name="p4Changelist" value="test_test_test"/>
>       <p4edit
>           view="${assemblyInfoFile}"
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"
>           failonerror="false"/>        <!--Already Checked out?-->
>
> The file ${assemblyInfoFile} is checked out against the changelist 1001
> and not the default changelist.
>
> And, if I do this:
>
>       <property name="p4Changelist" value="test_test_test"/>
>       <p4submit
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"/>
>
> The submit is done against changelist 1001 and not the default
> changelist.
>
> However, if I do this:
>
>       <property name="p4Changelist" value="test_test_test"/>
>       <p4revert
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"/>
>
> I get the following error:
>
> [p4revert] Usage: revert [ -a -n -k -c changelist# ] files...
> [p4revert] Missing/wrong number of arguments.
>
> Even worse, If I do this:
>
> <!-- I manually created Changelist #1001 for this Nant build -->
>       <property name="p4Changelist" value="1001"/>
>       <p4edit
>           view="${assemblyInfoFile}"
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"
>           failonerror="false"/>        <!--Already Checked out?-->
>
> Nant creates a new changelist with a description of "1001" instead of
> using Changelist #1001! At least this:
>
>       <property name="p4Changelist" value="1001"/>
>       <p4submit
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"/>
>
> Is using the same changelist as my original p4edit task (even its not
> the one I specified).
>
> However, this:
>
>       <property name="p4Changelist" value="1001"/>
>       <p4revert
>           changelist="${p4Changelist}"
>           client="${p4Client}"
>           port="${p4Port}"
>           user="${p4User}"
>           verbose="${isDebug}"/>
>
> Still gives me the following error:
>
> [p4revert] Usage: revert [ -a -n -k -c changelist# ] files...
> [p4revert] Missing/wrong number of arguments.
>
> I really don't mind if p4submit, p4edit, and other Perforce Nant tasks
> use the Changelist description and not the changelist number. It is also
> rather convenient that these tasks seem to create the changelist if one
> doesn't already exist with that description. However, the p4revert task
> is out of sync with the rest of the Perforce tasks, and the p4change
> task is pretty useless. Also, the "p4label" task doesn't work as
> documented. In the "p4label" task, you must have a "view" parameter
> while the documentation says it is optional.
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share 
> your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> NAntContrib-Developer mailing list
> NAn...@li...
> https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
>