From: Dominik G. <os...@gu...> - 2010-03-25 10:34:41
|
> On 64bit systems there are some environment variables which contains > parentheses like *ProgramFiles(x86)* or *CommonProgramFiles(x86)*. > This are invalid property names which cause the sysinfo tasks to fail. > > b) replace any parentheses in env.name with underscores and put this > into docu. > So I would like to go with b) since the properties could be used. > In addition docu states that function *environment::get-variable()* > should be used to retrieve env variables. So I think this won't affect a > lot of users. > Ok, I did some checks and will add some patches for discussion. (text in [[[ ]]] might be used for commit message as seen at svn mailing list) [[[ fix incorrect definition of "failonerror" in <sysinfo> docu. ]]] sysinfo-task-docu-error.patch sysinfo-replace-propname.patch: this is a first implementation to replace "sys.env.ProgramFiles(x86)" with "sys.env.ProgramFiles_x86_" There is still the docu change missing. But I will provide this when we are going this way. Result: --- snip --- [sysinfo] sys.env.ProgramFiles = C:\Programme [sysinfo] sys.env.ProgramFiles_x86_ = C:\Programme --- snap --- [[[ sort sysinfo properties when using verbose="true" ]]] sysinfo-verbose-sorted.patch: This patch will output properties on sorted order in verbose. I found that I need to search more than I like to find my replaced property without this sorting So far Dominik -- The answer to the great question of life, the universe and everything is 42 (Douglas Adams) |