[nant-dev] [ nant-Bugs-1802899 ] get usetimestamp="true" always download file

[SourceForge.net <no...@so...>]

Bugs item #1802899, was opened at 2007-09-26 18:07
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=402868&aid=1802899&group_id=31650

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tasks
Group: 0.85
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ahm4711 (ahm4711)
Assigned to: Nobody/Anonymous (nobody)
Summary: get usetimestamp="true" always download file

Initial Comment:
When setting usetimestamp to true, behaviour is not as described in the documentation. The requested file is always beeing download, allthougth the files timestamp has not changed on the server.
Just try below code twice and you will see that it "faq.html" is downloaded the second time as well (which should not happen).



	<target name="Bug">
		<get verbose="true" usetimestamp="true" src="http://nant.sourceforge.net/faq.html" dest="c:/faq.html" />
	<target name="GetZipAndInstall">




I had a look in the code and when changing the code from:

httpRequest.IfModifiedSince = gmtTime;

to

httpRequest.IfModifiedSince = fileLastModified;

in   private WebRequest GetWebRequest(string url, DateTime fileLastModified)

then behaviour seems to be correct! In any case I do not understand why the "gmtTime" hack there is needed.






----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=402868&aid=1802899&group_id=31650