Re: [mysitemaker-devel] Hard coded column names + date instructions fix

[Josh S. <jds...@un...>]

Thanks so much for the code patches.  Every little bit helps and if you
spot something else, let us know.  We'll try to incorperate them as
quickly as possible.

Thanks again.

Josh

Terry Alexis Lurie wrote:
> 
> I'm new to this code, so I didn't realise I'd have to change
> edit_record.cgi too. Here it is.
> 
> Terry.
> 
> Terry Alexis Lurie wrote:
> 
> > 1. The 3.5 code has some bugs. The select statements had some hard coded
> > table names id_num and option_name. I've changed these to figure them
> > out from the INPUT_OPTIONS and DIRECT_RELATIONS config.
> >
> > DIRECT_RELATIONS wasn't being considered. Now their values are put in a
> > hash %direct_relations.
> >
> > 2. Date fields: I think it should be stated that mySQL will take these
> > values in YYYY-MM-DD. Very important. Someone does need to check how
> > Postgress does this too, I don't use it.
> >
> > So possibly don't include that change to the code.
> >
> > Terry Lurie.
> > ---------------------------------------------------------
> > Terry Alexis Lurie | Aged Lawyers have a large collection
> > Computer Engineer  | distinguished books. Why is it that
> > GlobalVision.com   | aged Computer Engineers have a large
> > London             | collection of 'for Dummies...' ?
> >
> >
> > ------------------------------------------------------------------------
> >
> > 522d521
> > <                 $row_of_data[1] .= "<i>(YYYY-MM-DD)</i>";
> > 719c718
> > <     my($id_num,$option_name,$table_name, $order_by) = @_;
> > ---
> >
> >>    my($table_name, $order_by) = @_;
> >>
> > 723c722
> > <     my $query = "SELECT DISTINCT $id_num, $option_name FROM $table_name ORDER BY $order_by ASC";
> > ---
> >
> >>    my $query = "SELECT DISTINCT id_num, option_name FROM $table_name ORDER BY $order_by ASC";
> >>
> >>
> >>------------------------------------------------------------------------
> >>
> >>130,142d129
> >><
> >>< my $direct_relations = `./get_conf_data.pl DIRECT_RELATIONS $conf_file_name`;
> >>< chomp($direct_relations);
> >>< my @direct_relations = split(':', $direct_relations);
> >>< my (%direct_relations);
> >>< # option_types: values for this are: pulldown, multi, checkbox and radio
> >>< # r_col: a column in a relational table that contains values that we
> >>< #    want to join into the results from our query to the main table
> >>< foreach $direct_relation (@direct_relations) {
> >><     my ($col_name, $r_col_name) = split('=', $direct_relation);
> >><     $direct_relations{$col_name} = $r_col_name;
> >>< }
> >><
> >>226,238c213,215
> >><         my $option_related_table = $input_option_r_cols{$column_name};
> >><         my $related_table = $direct_relations{$column_name};
> >><
> >>< #Copy in raw data
> >><         my ($r_id_num)=$related_table;
> >><         my($r_option_name)=$option_related_table;
> >><
> >>< #Get out useful information
> >><         $r_id_num =~ s/^.*\.//; #strip off table
> >><         $r_option_name =~ s/^.*\.//;
> >><
> >><         $option_related_table =~ s/\..*?\Z//;
> >><         @all_options = $mySMDB->selectOptions($r_id_num,$r_option_name,$option_related_table, $r_id_num);
> >>---
> >>
> >>>         my $r_table = $input_option_r_cols{$column_name};
> >>>         $r_table =~ s/\..*?\Z//;
> >>>         @all_options = $mySMDB->selectOptions($r_table, "id_num");
> >>>
> 
> --
> Terry Lurie.
> ---------------------------------------------------------
> Terry Alexis Lurie | Aged Lawyers have a large collection
> Computer Engineer  | distinguished books. Why is it that
> GlobalVision.com   | aged Computer Engineers have a large
> London             | collection of 'for Dummies...' ?
> 
>   ------------------------------------------------------------------------
>                            Name: edit_record.cgi.diff
>    edit_record.cgi.diff    Type: Plain Text (text/plain)
>                        Encoding: 7bit