#24 various problems with menus

[Anonymous]

Further to bug #1283919, I have found several errors in
create_menus.cgi which corrupt the configuration if
menus of any kind are used. By comparing shared code
with select_fields.cgi I have found and (I think!)
corrected these as follows:

1. Language:: subscope left out on two adjacent lines.
This means that the search page is generated with no text.

line 257-8:
-foreach (keys %mySiteMaker::LGENSEARCH) {
- $template->param($_ => $mySiteMaker::LGENSEARCH{$_});
+foreach (keys %mySiteMaker::Language::LGENSEARCH) {
+ $template->param($_ =>
$mySiteMaker::Language::LGENSEARCH{$_});

2. mySiteMaker::Conffile contains no data. I'm not sure
why this is (mySiteMaker.pm contains an initialisation
statement), but myCGI->param('conf_file_name') contains
the correct info, so let's use it instead:

line 272:
-$template->param(CONF_FILE_NAME =>
$mySiteMaker::Conffile);
+$template->param(CONF_FILE_NAME =>
$myCGI->param('conf_file_name'));

line 279:
-$template->param(NEW_JAVASCRIPT_URL =>
"$base_cgi/limit_fields.cgi?conf_file_name="
.$mySiteMaker::Conffile);
+$template->param(NEW_JAVASCRIPT_URL =>
"$base_cgi/limit_fields.cgi?conf_file_name="
.$myCGI->param('conf_file_name'));

3. Bad reference to $column_name, which isn't used in
this file. Use $just_column instead.

line 285:
- if (!$no_sort{$column_name}) {
+ if (!$no_sort{$just_column}) {

Andrew Gallagher
andrewg at andrewg dot com

[Satya]

Logged In: YES
user_id=1022771

Thanks. I have added all this to CVS. 1. was already fixed :-)