Re: [myhdl-list] Github staging and works in progress

[Henry G. <he...@ca...>]

On 16/07/15 13:21, Jan Decaluwe wrote:
> On 07/16/2015 12:34 PM, Henry Gomersall wrote:
>> > On 16/07/15 08:54, Jan Decaluwe wrote:
>>> >> For every mediocre PR that I accept there will be 1 happy contributor
>>> >> and hunderds of users that hate me even more.
>> >
>> > Just on this point, you're rather drawing a false dichotomy. Of course
>> > you shouldn't accept bad PRs - I don't think anyone is suggesting you
>> > should. Rather, there needs to be a route by which bad PRs become good
>> > PRs, and that doesn't need to fall on you.
> Who are you, that you think you have anything to say about
> the way I choose to run my own open source project?
> 

Come on Jan, don't be so damn precious. I'm trying to help and your
response is distinctly confrontational. Of course you can run your
repository however you want, I'm just pointing out that perhaps there
are ways you could be more accommodating without compromising the quality.

> To those who are actually listening: the answer to the
> suggestion is (obviously) NO.
> 
> Of course many people have better Python skills than me,
> and I hope to see contributions from them. But I can
> hardly be an obstacle there: they don't need my guidance,
> and as can be seen from my track record I have little
> problems to judge the quality and incorporate them readily.

But this is the problem. Working on solutions in isolation is a very
*bad* way to do development. Nobody who is truly competent would try to
work like that unless they have to. Getting feedback through ongoing
code reviews is distinctly best practice. Currently this is very hard
with MyHDL.

> 
> For all other PR's, that are related to HDL-oriented
> decisions, I still have to meet the first person that
> I would trust to decide on them. For anybody who delves
> in the history of MyHDL, it will be obvious why.
> 
> I hope that is crystal clear.

Nobody is doubting your ability or authority when it comes to this
stuff, simply that if you're not keen to take a proactive role in the
refinement of PRs, other people can help with this. This isn't about
pushing crap into the repository, but about ironing out the problems in
pull requests before needing to bother you with them.

Please take my emails as what they are - a sincere and honest attempt to
refine the process of making MyHDL the best it can be.

Genuine best wishes,

Henry