[myhdl-list] Github staging and works in progress
Brought to you by:
jandecaluwe
From: Henry G. <he...@ca...> - 2015-07-14 18:10:28
|
As was raised during PR #102 on github, Jan's preference so far has been to have PRs that are complete and ready. I posit that allowing discussion and updates on specific implementation is a great feature of github and we should have a convention to allow for this, such that a solution can evolve with input inside a PR. @jck's suggestion of doing what neovim do seems like a great idea to me: Prefixing the title with one of the following tags: |[WIP] - Work In Progress: the PR will change, so while there is no immediate need for review, the submitter still might appreciate it. [RFC] - Request For Comment: the PR needs reviewing and/or comments. [RDY] - Ready: the PR has been reviewed by at least one other person and has no outstanding issues. | Only when the tag is changed to [RDY] is it deemed to be ready for inclusion. It would be great if github had a collaborative staging area, but this seems like a good solution to me. On a similar vein, I've sometimes failed to get useful feedback on specific implementations that are distinctly a work in progress, but need feedback to proceed. Specifically, issue #68 in which I have half of a complete implementation for that particular problem. It's distinctly not PR ready, but is a WIP. I'm somewhat disinclined to sink any more time into it without some further constructive feedback, which I attempted to garner without much success. I feel there is quite a bit that could be done very easily to make contributors feel more welcome. A mechanism for better and more patient code collaboration for WIPs would go a long way to this end. Perhaps if Jan doesn't wish to be involved with this, a second mirror repository on github could take on that role. Cheers, Henry |