Re: [myhdl-list] Another typo in docs

[Henry G. <he...@ca...>]

On 08/01/15 15:54, Christopher Felton wrote:
> On 1/8/2015 9:07 AM, Henry Gomersall wrote:
>> >On 08/01/15 15:01, Christopher Felton wrote:
>>> >>On 1/8/2015 8:44 AM, Henry Gomersall wrote:
>>>>> >>>>On 08/01/15 14:00, Christopher Felton wrote:
>>>>>>> >>>>>>This means that the doctest in the sphinx documentation
>>>>>>> >>>>>>might not be possible depending if the issue can be
>>>>>>> >>>>>>resolved.  Because there are multiple systems etc. not
>>>>>>> >>>>>>sure where/how to start debugging the issue.
>>>>>>> >>>>>>
>>>>>>> >>>>>>If more regression tests are desired it would be easier
>>>>>>> >>>>>>to create more tests than try and enable tests embedded
>>>>>>> >>>>>>in the documentation.
>>>>> >>>>
>>>>> >>>>I agree with this. However, as seems to be the case, it is possible to
>>>>> >>>>have a version of the code which has a test bench function rather than
>>>>> >>>>is a set of global operations which seems to work as desired (see the
>>>>> >>>>FSM code further down). If this is the case we can just change the
>>>>> >>>>structure of the code to fit that model.
>>>>> >>>>
>>> >>Is this what you currently have in your repo?
>> >Yup
>> >
>> >https://bitbucket.org/heng/myhdl/raw/641c450dac65cfa16edd42c45a43c101f3aa2db1/doc/source/manual/rtl.rst
>> >
> A quick look this looks good for a PR.  I will fork
> tonight and test on my system(s) as well.  I am a
> little confused why one of the expected output tables
> had to be changed (worried it is system dependent
> based on the random values even though it is seeded).

Do you mean changed from the original source you had up? Yeah, that 
concerned me slightly too - sorry, I should have noted that.

This would suggest it should be stable...
https://docs.python.org/3/library/random.html#notes-on-reproducibility

though this is worth noting too...
http://stackoverflow.com/questions/11929701/why-is-seeding-the-random-generator-not-stable-between-versions-of-python

Note that the always_comb code is replicated as it stands.

Henry