Re: [myhdl-list] AttributeError in 0.8-dev but not in 0.7
Brought to you by:
jandecaluwe
From: Christopher F. <chr...@gm...> - 2013-01-27 04:02:42
|
On 1/24/13 8:39 AM, Per Karlsson wrote: > Yes, I think you're right! It is mixing intbv[1:0] and bool that causes it. > Looking at this a little more the 0.7 code didn't check the types in the /_update/ function it simply assigned the /next/. I think the changes in 0.8 help support /Signal/s that contain different objects. I think the changes are good (it was a quick look, so I might be off). The simple change I made was to have the _setNextBool to always cast to a bool type. That way we won't have the /val/ of a /Signal/ changing from one type to another. Made a similar change with the _setNextInt This error should block 0.8 from being released. I will make a patch and post it with the description. I have not resolved the mixing /bool/ and /intbv(0)[1:]/ in the VHDL conversion. This should also be fixed and submitted as a single patch, when I get some more time I will tackle this next (or if someone resolves the issue :) ). All the non-conversion unit test in 0.8dev pass with these changes. All the general conversion tests pass also with the exception of two VHDL analyzed with GHDL tests but these two tests failed before the changes. Regards, Chris [1] https://bitbucket.org/cfelton/myhdl_tests/src/tip/test_mix_intbv_bool.py?at=default |