Re: [myhdl-list] intbv wrap

[Christopher F. <chr...@gm...>]

On 5/4/2011 10:13 AM, Ben wrote:
<snip>
>
> I was not aware of the state of your patch. I thought this was only a
> proof of concept. I'd be delighted to review it in its whole !
>
> Regards,
> Benoît

Thanks for the additional input!  And no problem, I posted the first 
rough patch a week or so ago.  I will think about limiting the change to 
_val only.  Because I have already made the changes and would have to 
undo or start over (which isn't a huge deal) I would prefer to clump the 
two changes together.

Since I have made the change, ran the regression tests, and ran new 
tests I would like to add the public val property in this patch, as 
well, if it is not too big an issue.  Just to save a little of my time. 
  In general, I agree, it is nice to keep changes separate and minimal. 
  Try to avoid including too many changes with one patch.

>
> As a side note your "I am still working on the test cases" is not
> really comforting, as the test case should be finished before you type
> the first line of code ;) ... in a perfect world.
>

I know, sigh, I had a small set of test cases first but I want to add 
more exhaustive tests and incorporate it with py.test.  The gen2 test 
framework in the distro.  For some reason, I have a horrible time 
getting py.py (py.test) installed.  I can't get easy_install installed 
to install py.test, doh.

Chris