Re: [myhdl-list] Signal getattr and setattr

[Jan D. <ja...@ja...>]

Chris:

I don't have a lot of time these days (moving to new house) but
did your patch mean that __slots__ is the problem?

I would hesitate a lot to apply a patch that customizes __setattr__,
and that makes every attribute access slower.

On the other hand, if __slots__ is the culprit, it would be one more
argument to remove it. Explanations later.

(Removing __slots__ shouldn't change signal behavior, but may
break some unit tests also.)

Jan



Christopher L. Felton wrote:
> Ignore the patch that was previously sent for now!  I was careless and 
> didn't run the regression tests.  After running the "tests" it exposed 
> some issues.  It appears this method breaks the properties.
> 
> Back to the drawing board.
> 
> .chris
> 
> Christopher L. Felton wrote:
>> Attached is a patch with some modification to __getattr__ and adds the 
>> __setattr__ in _Signal.py.
>>
>> I like the idea that the Signal class is "transparent".  Meaning that 
>> the object that the Signal contains, its (the contained object) 
>> attributes and properties can be accessed.
>>
>> The change checks the "slots" before accessing the "objects" (self._val) 
>> attributes.
>>
>> The patch fixes the bug I previously posted, max recursion depth.
>>
>> I think I generated the bundle/patch correctly and tried to verify with 
>> a separate repository clone.  The workspace I created the bundle from 
>> has additional changes (mainly error/warning statements and prints) that 
>> are not ready to be pushed.  The only changes should be the couple lines 
>> in _Signal.py
>>
>> .chris
>>
>>
>> ------------------------------------------------------------------------
>>
>> ------------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast and easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev 
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> myhdl-list mailing list
>> myh...@li...
>> https://lists.sourceforge.net/lists/listinfo/myhdl-list
> 
> 
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 


-- 
Jan Decaluwe - Resources bvba - http://www.jandecaluwe.com
    Python as a HDL: http://www.myhdl.org
    VHDL development, the modern way: http://www.sigasi.com
    Analog design automation: http://www.mephisto-da.com
    World-class digital design: http://www.easics.com