Re: [myhdl-list] _Waiter.diff [was: intbv.saturate, intbv.wrap]

[Jan D. <ja...@ja...>]

Christopher L. Felton wrote:
> I found another instance of the same/similar issue with the numpy array 
> while testing the latest change.  After the attached change and the 
> latest code from http://myhdl.sourceforge.net/hg/myhdl the code in 
> development ran without error.  Also all the test/core passed.

I believe you and have applied/pushed it.

> This should be a benign change because the previous code simply tested 
> "if obj".  Again the numpy array errors in this test.  Explicitly 
> testing that obj is not None, "obj != None" prevented the error.

... though I think the idiomatic test should be 'obj is not None'.

> I created (maybe?) one of those bundle things.  I don't quite have the 
> mercurial process down, I did a commit and wasn't able to diff after the 
> commit, which I guess make sense since there isn't no difference.

Of course, both commit and diff are local in your local repository.

All distributed revision control systems differ from centralized ones
in that they add a "second level" of commands. Some commands work
locally in your local repo's, some work between repo's. This is a
point that you'll have to understand in order to use it effectively.

 > But I
> wasn't sure what bundle did?  So I have a bundle before commit and 
> after. Figured it would take me a little longer to review the 
> documentation and didn't want to hold up the changes.

Look at it this way. After a (local) commit, you may want to publish
your changes, right?

To see the changes between your local repo and the parent repo:

hg out   # use the -vp option to review the patch

Now you would want to do:

hg push

to propagate your changes to the parent repo, just as you do
'hg pull' to download changes from the parent repo.

Except, this won't work for the myhdl repo at sourceforge. You can't
push to a http url, and moreover, I wouldn't let you :-)

Think of 'hg bundle' as an 'hg push' with me in the middle :-) It
does a similar thing, except that you have to send me the bundle file
and let me do the pull/push (after reviewing).

It's probably clear now why your pre-commit bundle didn't contain
any changesets, and why your post-commit bundle had the change
you described.

Jan

-- 
Jan Decaluwe - Resources bvba - http://www.jandecaluwe.com
Kaboutermansstraat 97, B-3000 Leuven, Belgium
     From Python to silicon:
     http://myhdl.jandecaluwe.com