[Mxquery-commit] SF.net SVN: mxquery:[4499] trunk/MXQuery/xqib_src/ch/ethz/mxquery/util/ browser/dom/DOMImpl.java

[<et...@us...>]

Revision: 4499
          http://mxquery.svn.sourceforge.net/mxquery/?rev=4499&view=rev
Author:   etterth
Date:     2011-10-21 20:16:23 +0000 (Fri, 21 Oct 2011)
Log Message:
-----------
- Fixed a bug that caused attributes to be returned twice

Modified Paths:
--------------
    trunk/MXQuery/xqib_src/ch/ethz/mxquery/util/browser/dom/DOMImpl.java

Modified: trunk/MXQuery/xqib_src/ch/ethz/mxquery/util/browser/dom/DOMImpl.java
===================================================================
--- trunk/MXQuery/xqib_src/ch/ethz/mxquery/util/browser/dom/DOMImpl.java	2011-10-21 19:32:27 UTC (rev 4498)
+++ trunk/MXQuery/xqib_src/ch/ethz/mxquery/util/browser/dom/DOMImpl.java	2011-10-21 20:16:23 UTC (rev 4499)
@@ -97,10 +97,7 @@
 
     public List<Attribute> elementGetAttributes(Element el) {
 	LinkedList<Attribute> ret = new LinkedList<Attribute>();
-	JsArray<Attribute> attrs = nativeElementGetAttributes(el);
-	for (int i = 0; i < attrs.length(); i++) {
-	    ret.add(attrs.get(i));
-	}
+
 	//TODO more input element types
 	if ("input".equals(el.getLocalName())) {
 	    if ("http://www.w3.org/1999/xhtml".equals(el.getNameSpaceURI())) {
@@ -108,13 +105,15 @@
 		if ("checkbox".equals(input.getType())
 			|| "radio".equals(input.getType())) {
 		    el.setAttributeNS("", "checked", Boolean.toString(input.getPropertyBoolean("checked")));
-		    ret.add((Attribute) el.getAttributeNode("checked"));
 		} else {
 		    el.setAttributeNS("", "value", input.getValue());
-		    ret.add((Attribute) el.getAttributeNode("value"));
 		}
 	    }
 	}
+	JsArray<Attribute> attrs = nativeElementGetAttributes(el);
+	for (int i = 0; i < attrs.length(); i++) {
+	    ret.add(attrs.get(i));
+	}
 	return ret;
     }
     

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.