#15 MaxUploads changes
As noted in RFE #676458, after running for a short time
with a few popular files, I get a large number of
requests that can't be satisfied because the queue is
full. This is due to the way that ReplyIfAvail works -
if a client stops a download, there is an interval
where the node returns search results even though there
are many clients already waiting to download.
This patch splits MaxUploads into MaxUploadsSoft and
MaxUploadsHard. If ReplyIfAvail is enabled, search
results will only be returned if the number of
downloads is below MaxUploadsSoft, while MaxUploadsHard
specifies the absolute maximum number of uploads.
This dramatically reduces the number of busy replies
that need to be sent. It also increases the likelihood
that a user will be able to download a file returned in
a search result.
This patch applies against whatever cvs version is
available on the date of this upload. It should close
RFE #676458. Feedback appreciated.
Logged In: YES
user_id=337781
Interesting patch, but I'd rather have a typical hardcoded ratio between the MaxUploads and "SoftMaxUploads". What whould be the optimum out of your experience? And, better write me an email, it's easier to discuss this that way.
--Max