From: Lars K. <li...@su...> - 2017-04-25 19:09:24
|
Hi, there is a new pull request for the contrib repository: https://github.com/munin-monitoring/contrib/issues/839 It proposes to make the graph_title of the "dirsizes" plugin [1] configurable via a environment variable. The contributor of the pull request would like to use a different title for the "dirsizes" graph on different hosts. Personally I would tend to dismiss this proposal, since most plugins with a similar scope (e.g. diskstats_iops) use a static title. This works well, since the type of the visualized information is always the same - even though the graphs involve different resources / disks / directories on each host. In other words: I do not think that this use-case justifies the increased complexity of that plugin. On the other hand: we are usually quite liberal with regards to the plugins in the contrib repository. Thus it may feel weird, if we reject a proposal based on non-technical reasons. What do you think? Cheers, Lars [1] https://github.com/munin-monitoring/contrib/blob/master/plugins/disk/dirsizes |