Re: [munin-users] Installing on Solaris + non-standard Perl path

[Magnus H. <ma...@ha...>]

On Mon, Oct 18, 2010 at 23:41, Nicolai Langfeldt
<ja...@re...> wrote:
> On 18. okt. 2010 22:58, Magnus Hagander wrote:
>>>>
>>>> I altered Makefile.config to point to the perl I want to, thus:
>>>> PERL := /app/usr/local/bin/perl
>>>
>>> ...
>>>>
>>>> :::-->head -1 munin-node-configure
>>>> #!/usr/bin/perl
>>>
>>> That's impossible ;-)
>>
>> Is it really? AFAICT, munin-node-configure has a hardcoded path to
>> perl - as does a bunch of other scripts:
>> mha@mha-laptop:/opt/munin-src/munin.git$ git grep "/usr/bin/perl"
>> common/lib/Munin/Common/Defaults.pm:our $MUNIN_PERL       =
>> '/usr/bin/perl';
>
> For Defaults.pm we have a very advanced perl RE in the Makefile:
>
>        $(PERL) -pe 's{(PREFIX     \s+=\s).*}{\1q{$(PREFIX)};}x;   \
> ...
>                  s{(PERL       \s+=\s).*}{\1q{$(PERL)};}x;        \
> ...
>
> So that's all right, and that should also be where plugins take @@PERL@@
> from.

No, I believe plugins take it from the sed command just above it in
that Makefile, no?


>> master/_bin/munin-update.in:#! /usr/bin/perl
>> node/bin/munindoc:#!/usr/bin/perl -w
>> node/sbin/munin-node:#!/usr/bin/perl -wT
>> node/sbin/munin-node-configure:#!/usr/bin/perl -w
>> node/sbin/munin-run:#!/usr/bin/perl -T
>> plugins/node.d/testplugin:#!/usr/bin/perl
>>
>>
>> Shouldn't they all really be using @@PERL@@? If not, what's the reason
>> that some shouldn't?
>
> I've removed some "contrib" and other things from your list above, but right
> now it seems that the six mentioned above are bugs yes.  I looked in trunk,
> I wonder what 1.4 looks like :I

So you're going to fix this, right? ;)


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/