#2421 Missing ":" in password reset email link

[Anonymous]

I notice the reset password link in the email is mistake.
instead http:// and it only give http// , the missing of ":" can I know where or how to add in to correct this?
http//xxx.com/reset_password.php
Thank you.

[Anonymous]

Appreciate anyone can help. I'm new in this system.

[Campbell Morrison]

Which release of MRBS are you running?

[Anonymous]

the latest 1.9.4

[Campbell Morrison]

I can't reproduce this. The code also looks OK (lines 371-374 of lib/MRBS/Auth/AuthDb.php):

    $query = http_build_query($vars, '', '&');
    $href = (\MRBS\is_https()) ? 'https' : 'http';
    $href .= '://' . \MRBS\url_base() . \MRBS\multisite("reset_password.php?$query");
    $body .= "<p><a href=\"$href\">" . \MRBS\get_vocab('reset_password') . "</a>.</p>";

Can you post the email body here (with any domain names removed)?

[Anonymous]

Hmm... Thanks for your reply.
I think I found the typo.
Instead I type in my full url (http://xxxx.com) in config.inc.php, I should just type in without http://
Problem solve. I was confuse by the example in config.inc.php
Thank you. Problem solved now.

[John Beranek]

Was thinking this is just a typo in config.inc.php for $url_base ?

[Anonymous]

Thanks for your reply.
Yes. $url_base that I type in full url (http://xxxx.com) cause error.
The example confused me. I should type in only xxx.com in $url_base and problem solved.

[Campbell Morrison]

Good, glad it's working now. The example is in fact correct, but there was a bug in the code which I have now fixed (see below).

[Anonymous]

Thanks. Appreciate the assist. Can close this ticket since resolved.

[Campbell Morrison]

Mmmm. I don't think so, because the reset code adds on http|https:// to $url_base. It shouldn't do, but that's a separate bug I'll need to fix.

[Campbell Morrison]

I've fixed that particular bug on 57ec94f. Though I don't think that's the cause of the original problem.