As MRBS stands at the moment it would be difficult to make approval be by a room or area admin - unless they were also an admin. That's because room and area admins aren't defined by their usernames but just have email addresses associated with them.
However it would be possible to implement approval by admins - and you could arrange for your room and area admins to have MRBS admin access (it's a bit confusing with the two different kinds of admin). If you were using the db authentication scheme you could also define a number of different levels of admin so that the room and area admins didn't have to have full MRBS admin rights.
Would approval by admins, as described above, still be useful for you?
Campbell
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sound good to me! I guess you could do a lookup when the room/area admin is edited to make sure that email address is associated with a valid user.
cheers,
John
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm also interested in seeing this, or something similar implemented (even if only admins could approve bookings).
Is anyone currently working on this? If not then I'll happily take a look at it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since this now seems to be implemented (yeah, I managed to overlook this somehow -- set $provisional_bookings config option to TRUE to enable it) why is this ticket not closed? Or have I missed something else?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes - you're right. Provisional bookings are now implemented. However, approval is by MRBS admins rather than room or area admins, so I guess that's why it's not closed.
Campbell
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
In MRBS 1.4.11 you'd have to modify the function auth_book_admin() in mrbs_auth.inc to check whether the user's email address was the same as the area admin's email address.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you for the quick response. I am new to PHP and coding. Could you please help me with a code snippet from which i can work with? Like a small example or something?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, I'm afraid I don't have time to provide an example. If you want to modify MRBS you'll either need to learn PHP, or else find somebody who can help.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I know this a really old request. But sifting through the code I found some preparations for authenticating a room admin so that it can be used to actually let the room/area admin do the approval.
I would be really interested in this feature and willing to do some development in that direction. I have a limited experience in writing php-code but have programmed in various other languages (Fortran [yay], C, C++, Python and some application specific scripting languages). Anything I need to know before starting?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks. Testing the roles branch would be the most useful thing. If you're using the 'db' or 'ldap' authentication types it should work, so let me know if you spot any problems. (It makes major changes to your table structure so I would not test the roles branch in a production setting).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2023-02-03
I will install a Testversion locally, db-authentication and I think even ldap is fine here. Locally I use postgres, does that play a role?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'd like to see something like this too.
in attached file, portuguese language file updated
I would also find this feature very useful.
As MRBS stands at the moment it would be difficult to make approval be by a room or area admin - unless they were also an admin. That's because room and area admins aren't defined by their usernames but just have email addresses associated with them.
However it would be possible to implement approval by admins - and you could arrange for your room and area admins to have MRBS admin access (it's a bit confusing with the two different kinds of admin). If you were using the db authentication scheme you could also define a number of different levels of admin so that the room and area admins didn't have to have full MRBS admin rights.
Would approval by admins, as described above, still be useful for you?
Campbell
Sound good to me! I guess you could do a lookup when the room/area admin is edited to make sure that email address is associated with a valid user.
cheers,
John
I'm also interested in seeing this, or something similar implemented (even if only admins could approve bookings).
Is anyone currently working on this? If not then I'll happily take a look at it.
Since this now seems to be implemented (yeah, I managed to overlook this somehow -- set $provisional_bookings config option to TRUE to enable it) why is this ticket not closed? Or have I missed something else?
Yes - you're right. Provisional bookings are now implemented. However, approval is by MRBS admins rather than room or area admins, so I guess that's why it's not closed.
Campbell
Any update on the area administrator feature? Can someone help me with this?
In MRBS 1.4.11 you'd have to modify the function auth_book_admin() in mrbs_auth.inc to check whether the user's email address was the same as the area admin's email address.
Hi Campbell,
Thank you for the quick response. I am new to PHP and coding. Could you please help me with a code snippet from which i can work with? Like a small example or something?
Hi Campbell,
Any update on this?
Thank you.
Sorry, I'm afraid I don't have time to provide an example. If you want to modify MRBS you'll either need to learn PHP, or else find somebody who can help.
I know this a really old request. But sifting through the code I found some preparations for authenticating a room admin so that it can be used to actually let the room/area admin do the approval.
I would be really interested in this feature and willing to do some development in that direction. I have a limited experience in writing php-code but have programmed in various other languages (Fortran [yay], C, C++, Python and some application specific scripting languages). Anything I need to know before starting?
The modification to the code isn't that complicated. See https://sourceforge.net/p/mrbs/support-requests/2286/. The exact details may need to be changed slightly for the current release.
In the longer term the roles branch will provide this functionality (and more) as standard, but it isn't finished yet.
Thanks a bunch, it looks like it's working quite nicely. Anything I can do to support the roles branch?
Thanks. Testing the roles branch would be the most useful thing. If you're using the 'db' or 'ldap' authentication types it should work, so let me know if you spot any problems. (It makes major changes to your table structure so I would not test the roles branch in a production setting).
I will install a Testversion locally, db-authentication and I think even ldap is fine here. Locally I use postgres, does that play a role?
Yes, it should work with PostgreSQL.