#544 $reminders_enabled and the "more info" button do not work if none of the notification settings in $mailsettings is enabled

[Stefan Muenkner]

Hi,

I first posted it a about a week ago under support requests. I am not certain whether this unexpected behaviour or a real bug. Raw patches to fix it below

We set up the approval scheme here, but found that the automatic sending of notifications generated way too much mail traffic. I then enabled the users to manually send reminders (via $reminders_enabled=TRUE) to the room admins disabling all other notifications configured via $mail_settings[], so that they can send a notification when e.g. they are finished entering their bookings.

I found out that no notification mails were sent using the "Remind administrator" button. It turns out, that the approve_entry_handler only sends emails, when the function "need_to_send_mail()" in functions_mail.inc returns TRUE, i.e. when any of the notification settings via $mail_settings are are set to TRUE. The same seemed to be true for the "More info" button, which seems to have no function unless any of the notification settings in $mail_settings[] are set to TRUE.

Since the settings below control an automatic behavior but the "remind administrator" and "request more info" are manual actions, I really do not see, why the latter should depend on the settings below.

$mail_settings['admin_on_bookings']      = false;  // the addresses defined by $mail_settings['recipients'] below
$mail_settings['area_admin_on_bookings'] = false;  // the area administrator
$mail_settings['room_admin_on_bookings'] = false;  // the room administrator
$mail_settings['booker']                 = false;  // the person making the booking
$mail_settings['book_admin_on_approval'] = false;  // the booking administrator when booking approval is enabled

Attached are two small patches that - at least for me - fix the problems. The first for approve_entry_handler.php introduces a new variable which signals that a mail should be sent and is also set to TRUE for the "remind" and "more_info" actions. The second patch for functions_mail.inc enables create_addresses() to return addresses if the action is "more_info", even when the above $mail_settings are all set to false.

Best regards
Stefan

[Campbell Morrison]

Many thanks. I'll look at them next week hopefully.