Menu

#517 Just a little quirk

Future_Requests
open
nobody
None
1
2022-01-25
2022-01-24
Philippe
No

Just as a heads up: the help.php file at line 80 should read

require_once "site_faq/site_faq_" . $faqfilelang . ".html";
instead of
require_once "site_faq/site_faq" . $faqfilelang . ".html";

otherwise the additional file faq doesn't load and issues a warning :-)

Cheers
Philippe

Discussion

  • Campbell Morrison

    Strictly speaking it's not a bug. The comments in systemdefaults.inc.php say

    // faq file language selection. IF not set, use the default english file.
    // IF your language faq file is available, set $faqfilelang to match the
    // end of the file name, including the underscore (ie. for site_faq_fr.html
    // use "_fr"
    $faqfilelang = "";
    

    It's been that way since at least MRBS 1.2.6. If we were to make the change above then all those systems that correctly have

    $faqfilelang = "_fr";
    

    would stop working.

    However I agree it's confusing. What I think I'll do is make the code check for an underscore in the file name and add one if it's not present, so that both usages will work.

     
  • Campbell Morrison

    I've now fixed this in 337dd6c.

     

    Last edit: Campbell Morrison 2022-01-25