Re: [Mplayerplug-in-devel] SMIL area tag patch
Brought to you by:
kdekorte
From: David M. <dme...@be...> - 2004-02-26 02:20:27
|
On Wed, Feb 25, 2004 at 01:22:45PM -0700, Kevin DeKorte wrote: > Pere, > > I have merged your patch into CVS. It should be available from there in a few > hours. There is one mistaken usage of sscanf in this patch: the field width has to be the size of the buffer string, minus 1. Otherwise there is a possibility of a one-byte overflow and the string will not be null-terminated, leading to "bad stuff". This is done correctly in one place but incorrectly in another. I also noticed this problem exists in another place too (although in that case it's when reading from mplayer's output, and not remotely suppliedI think). Here's a patch to fix both. Peace, Dave |