Re: [mpg123-devel] Please test new network code in/out of mpg123 (now with HTTPS support)!

[Thomas O. <tho...@or...>]

Am Fri, 13 May 2022 23:35:23 -0700
schrieb Dave Yeo <dav...@gm...>: 

> As far as I know, all OS/2 compilers define __OS2__, so would be fine.

> No, EMX is likely to outdated to compile MPG123 without a lot of work, 

So I'll switch all ifdefs  to __OS2__ and will drop the EMX bits. Less
cruft.

> Actually I hadn't used terminal control previously. Now adding -v to the 
> command line, I get this message,
> Terminal control enabled, press 'h' for listing of keys and functions.

OK … so getting the window size works.

> but 'h' nor any other key besides CTRL-C does anything and displays on 
> the command line after mpg123 exits. Never noticed before.

Better try without -v (less obscuring). So you press a key and it
appears after mpg123 ends? No reaction … hm. Ah, of course. Would
things suddenly happen if you didn't press 'h', but 'h' + 'return'?

We switch the terminal into non-canonical mode, which also turns off
line buffering, using tcsetattr. I wonder: Does OS/2 implement
cfmakeraw(), perhaps? That one could be used instead. You could
experiment in src/term.c, in

void term_init(void)

Instead of calling tcgetattr() and term_setup(), OS/2 could just do
cfmakeraw(), if that one is implemented instead. Or is there anything
else that enables unbuffered terminal input? I imagine that OS/2 must
have applications that react to keypresses in the terminal!

Maybe finding a solution here would also fix terminal control on
Mingw/Windows …


Alrighty then,

Thomas