Re: [mpg123-devel] Please test new network code in/out of mpg123 (now with HTTPS support)!

[Thomas O. <tho...@or...>]

Am Fri, 13 May 2022 19:13:02 -0700
schrieb Dave Yeo <dav...@gm...>: 

> Yes the build works fine now. Still need to workaround for os2me.h, need 
> something like,

> --- configure.ac        (revision 5065)
> +++ configure.ac        (working copy)
> @@ -1945,6 +1945,7 @@
>                  ;;
>                  os2)
>                          OS2_LIBS="-lcx -lmmpm2"
> +                        CFLAGS+="-idirafter /@unixroot/usr/include/os2tk45"
>                          AC_CHECK_HEADERS([os2.h])
>                          # os2me.h depends on os2.h
>                          # Yes, that way of coding it is ugly.
> @@ -1953,6 +1954,7 @@
>                                  # We mimick exactly the way how the 
> header will
> be used.
>                                  # It seems to be picky...
>                                  AC_CHECK_HEADERS([os2me.h], [], [], 
> [#define INC
> L_OS2MM
> +#undef VERSION

OK, the undef VERSION is easy, I guess. But that business about the
different headers … 

1. This is just for the OS/2 audio output, os2me, right?

2. You need the -idirafter in CFLAGs for the output module build only,
   yes?

> The above works for configure but the -idirafter doesn't end up in the 
> makefiles.

Is it present in the final configure printouts about the configuration?

But anyway, it should be put into OS2_CFLAGS, anyway. That is applied in

src_libout123_modules_output_os2_la_CFLAGS  = $(MODULE_CFLAGS) @OS2_CFLAGS@

Or does the overall build also need this? Then we need to add those
flags elsewhere. But I also wonder how generic this setting is. For how
many users besides yourself are we doing this? ;-)


Alrighty then,

Thomas