Re: [mpg123-devel] Please test new network code in/out of mpg123 (now with HTTPS support)!

[Thomas O. <tho...@or...>]

Am Fri, 13 May 2022 07:46:11 -0700
schrieb Dave Yeo <dav...@gm...>: 

> Strictly speaking, __OS2__ covers all compilers, __EMX__ covers all 
> versions of GCC, and __KLIBC__ covers the current GCC/libc (a mostly 
> compatible rewrite of EMX's libc using BSD licensing rather then GPL) 
> and GCC.

So this looks like we should use __OS2__. Is it identical with the
plain OS2 (no underscores) that we have littered on the source right
now?

> > Also, this snippet in local.c:
> >
> > #ifdef __EMX__
> > /* Special ways for OS/2 EMX */
> > #include <stdlib.h>
> > #else
> > /* POSIX stuff */
> > #ifdef HAVE_TERMIOS
> > #include <termios.h>
> > #include <sys/ioctl.h>
> > #endif
> > #endif
> >
> > Does that make sense, still (if anytime)? Do you have termios and
> > terminal control in mpg123?  
> 
> It worked fine with EMX, now tcsetattr() is missing so we get,
> [../mpg123.svn/src/term.c:term_init():154] error: failed to get terminal 
> attributes: Invalid argument

It worked with EMX? But we explicitly disabled termios there?

So, should I just drop this ifdef and use HAVE_TERMIOS as-is, and you
eventually sort out the runtime problem with tcsetattr(). Or even more:
Could terminal control work for you (in the end, it's just
select(STDIN_FILENO)), just not with meddling with the attributes?
Works isatty() on OS/2? We could use that for more proper terminal
detection than messing with attributes.


Alrighty then,

Thomas