Re: [mpg123-devel] Please test new network code in/out of mpg123 (now with HTTPS support)!

[Dave Y. <dav...@gm...>]

On 05/12/22 11:46 PM, Thomas Orgis wrote:
> Am Thu, 12 May 2022 20:11:50 +0200
> schrieb Thomas Orgis <tho...@or...>:
>
>> Now for a correct preprocessor guard... either platform check or
>> simply if setmode is available.
>
> Can we clarify that?
>
> We have
>
> #ifdef OS2
>
> and
>
> #ifdef __EMX__
>
> Which one is better?

Strictly speaking, __OS2__ covers all compilers, __EMX__ covers all 
versions of GCC, and __KLIBC__ covers the current GCC/libc (a mostly 
compatible rewrite of EMX's libc using BSD licensing rather then GPL) 
and GCC.
I usually use __OS2__ mostly as it more clear then __EMX__ but if 
someone was to compile mpg123 with OpenWatcom etc, which should work 
given a makefile, those differences become important.


> Also, this snippet in local.c:
>
> #ifdef __EMX__
> /* Special ways for OS/2 EMX */
> #include <stdlib.h>
> #else
> /* POSIX stuff */
> #ifdef HAVE_TERMIOS
> #include <termios.h>
> #include <sys/ioctl.h>
> #endif
> #endif
>
> Does that make sense, still (if anytime)? Do you have termios and
> terminal control in mpg123?

It worked fine with EMX, now tcsetattr() is missing so we get,
[../mpg123.svn/src/term.c:term_init():154] error: failed to get terminal 
attributes: Invalid argument
Eventually I expect tcsetattr() to be redone, but who knows if it will 
happen.
Thanks,
Dave