Re: [mpg123-devel] Microsoft Visual Studio 2010

[Patrick D. <pa...@my...>]

Hi Charles,

On Mon, Jan 16, 2012 at 5:24 PM, Charles Van Winkle <cva...@ad...> wrote:

> I'd like to propose a small change to /ports/MSVC++/mpg123.h to be better compatible with Visual Studio 2010, and other projects that might already define int32_t and uint32_t differently than what is in this header.
>
> Lines 14-16 in this header which are:
>
> 14      typedef long ssize_t;
> 15      typedef __int32 int32_t;
> 16      typedef unsigned __int32 uint32_t;
>
> Would become lines 14-22:
>
> 14      typedef long ssize_t;
> 15+
> 16+     // Needed for Visual Studio versions before VS 2010.
> 17+     #if (_MSC_VER < 1600)
> 18      typedef __int32 int32_t;
> 19      typedef unsigned __int32 uint32_t;
> 20+     #else
> 21+     #include <stdint.h>
> 22+     #endif

Sounds good to me. I have applied this change to svn as of revision 2997.

> If interested, I could also submit the VS2010 solution and projects, but I hesitate to do that until I figure out what is going on with these errors from the upgrade log:

VS2010 projects are already part of libmpg123. If they did not work
for you it would be great to know why.

Thanks for your help!

Patrick