[mpg123-devel] Microsoft Visual Studio 2010

[Charles V. W. <cva...@ad...>]

Greetings all,

I've been working with mpg123 for several months on an unreleased commercial product.  This is my first post so far.

I'd like to propose a small change to /ports/MSVC++/mpg123.h to be better compatible with Visual Studio 2010, and other projects that might already define int32_t and uint32_t differently than what is in this header.

Lines 14-16 in this header which are:

14	typedef long ssize_t;
15	typedef __int32 int32_t;
16	typedef unsigned __int32 uint32_t;

Would become lines 14-22:

14	typedef long ssize_t;
15+	
16+	// Needed for Visual Studio versions before VS 2010.
17+	#if (_MSC_VER < 1600)
18	typedef __int32 int32_t;
19	typedef unsigned __int32 uint32_t;
20+	#else
21+	#include <stdint.h>
22+	#endif

This allows someone to compile under Visual Studio 2010 if they copy the existing VS 2008 solution and convert it to VS 2010.  It also allows my project to avoid collision which also previously defines int32_t and uint32_t when I include this header.   I've verified that the solution compiles and builds in both VS 2008, and VS 2010.  I have not tested VS 2005, but I'm confident it would behave in the same way as VS 2008 in this change.

If interested, I could also submit the VS2010 solution and projects, but I hesitate to do that until I figure out what is going on with these errors from the upgrade log:

<Event ErrorLevel="1" Project="libmpg123" Source="libmpg123\libmpg123.vcproj" Description="VCWebServiceProxyGeneratorTool is no longer supported. The tool has been removed from your project settings."></Event>
<Event ErrorLevel="1" Project="mpglib" Source="mpglib\mpglib.vcproj" Description="VCWebServiceProxyGeneratorTool is no longer supported. The tool has been removed from your project settings."></Event>
<Event ErrorLevel="1" Project="mpglib" Source="mpglib\mpglib.vcproj" Description="Attribute 'CopyLocalDependencies' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="mpglib" Source="mpglib\mpglib.vcproj" Description="Attribute 'UseDependenciesInBuild' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="feedseek" Source="feedseek\feedseek.vcproj" Description="VCWebServiceProxyGeneratorTool is no longer supported. The tool has been removed from your project settings."></Event>
<Event ErrorLevel="1" Project="feedseek" Source="feedseek\feedseek.vcproj" Description="Attribute 'CopyLocalDependencies' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="feedseek" Source="feedseek\feedseek.vcproj" Description="Attribute 'UseDependenciesInBuild' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="scan" Source="scan\scan.vcproj" Description="VCWebServiceProxyGeneratorTool is no longer supported. The tool has been removed from your project settings."></Event>
<Event ErrorLevel="1" Project="scan" Source="scan\scan.vcproj" Description="Attribute 'CopyLocalDependencies' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="scan" Source="scan\scan.vcproj" Description="Attribute 'UseDependenciesInBuild' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="dump_seekindex" Source="dump_seekindex\dump_seekindex.vcproj" Description="VCWebServiceProxyGeneratorTool is no longer supported. The tool has been removed from your project settings."></Event>
<Event ErrorLevel="1" Project="dump_seekindex" Source="dump_seekindex\dump_seekindex.vcproj" Description="Attribute 'CopyLocalDependencies' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>
<Event ErrorLevel="1" Project="dump_seekindex" Source="dump_seekindex\dump_seekindex.vcproj" Description="Attribute 'UseDependenciesInBuild' of 'ProjectReference' is not supported in this version and has been removed during conversion."></Event>

-Charles Van Winkle
Adobe Systems, Inc.