Re: [mpg123-devel] id3v2 picture support for mpg123

[Thomas O. <tho...@or...>]

Am Tue, 6 Sep 2011 08:48:05 -0700 (PDT)
schrieb Anthony Wells <bor...@ya...>: 

> I had recently added id3v2 APIC frame support to mpg123.  (Was using it to retrieve the cover art from my Amazon mp3's)
> 
> Would this be something the mpg123 community might be interested in?

Yeah, I will have a look at the patch in the next time slot (no promise about temporal proximity, though). While you're at it, you could also add support for lyrics --- there's a feature request tracker item for that;-) But back to the point: With images, I think one should probably not enable extraction by default to prevent unneded memory use ... but then, there is memory temporaryly allocated for the whole tag anyway for parsing.

Have to think clearly about that and it doesn't affect the question if one should add that support at all. Generally, I agree that we should have a sensible coverage of ID3v2 tag info in libmpg123. Why not include album art? Even the frontend can sport an option to extract those pictures. Though, it might be better to expand the id3dump example to handle this metadata stuff. In any case: On with the patches!


Alrighty then,

Thomas.