#212 Please don't #define EXPORT in mpg123.h

[John Lindgren]

Using mpg123 1.20.1 here on Arch Linux.

I'm trying to build a shared library (specifically, the mpg123 plugin for Audacious) with -fvisibility=hidden, using EXPORT as a synonym for __attribute__((visibility("default"))) to mark the symbols which are intended to be public. mpg123.h is getting in the way by redefining EXPORT to nothing. I can probably work around the problem, but please use MPG123_EXPORT instead. Library headers really shouldn't hijack an identifier as generic as EXPORT.

[Thomas Orgis]

Hm, I'm still not getting the hang of the sf.net tracker behaviour with E-Mail. Anyhow, at the possibility of duplication:

I can probably work around the problem, but please use MPG123_EXPORT instead. Library headers really shouldn't hijack an identifier as generic as EXPORT.

That's right and I have to wonder why it took so long for someone to
complain. SVN revision 3583 contains the suggested change. After you
confirm that the current http://mpg123.org/shapshot works for you, I
should be going to make this the next release.

[Thomas Orgis]

Am Sun, 28 Sep 2014 07:11:23 +0000
schrieb "John Lindgren" jpl1990@users.sf.net:

I can probably work around the problem, but please use MPG123_EXPORT instead. Library headers really shouldn't hijack an identifier as generic as EXPORT.

That's right and I have to wonder why it took so long for someone to
complain. SVN revision 3583 contains the suggested change. After you
confirm that the current http://mpg123.org/shapshot works for you, I
should be going to make this the next release.

[Thomas Orgis]

Hah, I knew it would result in duplication. I need to adjust my expectation of the speed of light concerning electric signals travelling via SMTP to sf.net.

[John Lindgren]

The snapshot works for me, thanks!