At current implementation, ppp-max-payload tag will be sent only, if in config file found this line:
set pppoe max-payload XXX
You are deleted this verification
Last edit: Dmitry S. Lukhtionov 2015-11-12
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If you make a connection that needs the Max-Payload tag, then disconnect, reconfigure to an MTU <= 1492 and reconnect, both the log and packet capture shows that the previously configured Max-Payload tag is sent unnecessarily. Unfortunately, I failed to keep the log and packet capture, as they came as part of a long debug and test session. I simply fixed the issue and moved on.
The patch fixes an observed problem, and I urge its incorporation before mpd 5.8 has shipped. It has now been shipped in the FreeBSD mpd5 port via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203695 , so failure to incorporate this patch will lead to a regression.
The good news is that, apart from this issue, the RFC 4638 code works well. It has been in production at my site for several months.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
At current implementation, ppp-max-payload tag will be sent only, if in config file found this line:
set pppoe max-payload XXX
You are deleted this verification
Last edit: Dmitry S. Lukhtionov 2015-11-12
If you make a connection that needs the Max-Payload tag, then disconnect, reconfigure to an MTU <= 1492 and reconnect, both the log and packet capture shows that the previously configured Max-Payload tag is sent unnecessarily. Unfortunately, I failed to keep the log and packet capture, as they came as part of a long debug and test session. I simply fixed the issue and moved on.
The patch fixes an observed problem, and I urge its incorporation before mpd 5.8 has shipped. It has now been shipped in the FreeBSD mpd5 port via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203695 , so failure to incorporate this patch will lead to a regression.
The good news is that, apart from this issue, the RFC 4638 code works well. It has been in production at my site for several months.