#11 Errors Compiling Current subversion trunk

[Michael Ditum]

Hi,

I've come across a couple of compilation issues when compiling the current svn trunk. They are...

1. Undefined Reference

When linking the mp4dump util it fails with the following message:

g++ -Wall -Werror -Wno-char-subscripts -Woverloaded-virtual -Wno-unknown-pragmas -Wno-deprecated -Wformat=2 -Wpointer-arith -Wsign-compare -fno-strict-aliasing -g -O2 -DMPEG4IP -o .libs/mp4dump mp4dump.o ../../../lib/mp4v2/.libs/libmp4v2.so ../../../lib/gnu/.libs/libmpeg4ip_gnu.so
../../../lib/mp4v2/.libs/libmp4v2.so: undefined reference to `MP4ChplAtom::MP4ChplAtom()'
collect2: ld returned 1 exit status

This happens because the atom_chp1.cpp script isn't being included in the libmp4v2 object. I've attached a patch to fix this issue.

2. converting to non-pointer type ‘int’ from NULL

Whilst compiling server/mp4creator/mp4creator.cpp it fails with the warning (that is turned into an error) of:

cc1plus: warnings being treated as errors
mp4creator.cpp: In function ‘int main(int, char**)’:
mp4creator.cpp:535: warning: converting to non-pointer type ‘int’ from NULL
make[3]: *** [mp4creator.o] Error 1

I've attached a patch which fixes this by changing the NULL to 0.

3. converting to ‘uint64_t’ from ‘double’

When compiling server/mp4creator/qtchap.cpp it fails with the warning (that is turned into an error) of:

cc1plus: warnings being treated as errors
qtchap.cpp: In function ‘uint32_t import_chapter_file(MP4Chapters_t**, FILE*, double)’:
qtchap.cpp:236: warning: converting to ‘uint64_t’ from ‘double’
make[3]: *** [qtchap.o] Error 1

I've attached a patch that fixes this by making the cast explicit.

When these 3 patches have been applied the svn version compiles correctly on FC5.

[Michael Ditum]

Patch to fix issue 1. Undefined Reference

[Michael Ditum]

Patch to fix issue 2. converting to non-pointer type ‘int’ from NULL

[Michael Ditum]

Patch to fix issue 3. converting to ‘uint64_t’ from ‘double’