#59 heap-buffer-overflow in apetag.c:260:5

[Kim Davies]

heap-buffer-overflow in apetag.c:260:5

Environment:

Distributor ID: Ubuntu
Description: Ubuntu 24.04.1 LTS
Release: 24.04

Compiler:

Ubuntu clang version 14.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix

Compiling:

CFLAGS="-fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer -g" CXXFLAGS="-fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer -g" make

Version:

commit f669c2c826411c132655be66465077e77f25d93d

PoCfile:

Unzip poc.zip.

Behavior:

./mp3gain poc/mp3gain_003.poc

Output:

/home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:296:39: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:296:39 in 
=================================================================
==770181==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000000b6 at pc 0x56359ea4f19b bp 0x7ffd4a701e10 sp 0x7ffd4a7015e0
READ of size 3 at 0x6020000000b6 thread T0
    #0 0x56359ea4f19a in __asan_memcpy (/home/exp/bin/asan_ubsan/mp3gain+0xd219a) (BuildId: 6adba16c3fc2a25561194f170abc8ab9f4e2b498)
    #1 0x56359eab9f22 in ReadMP3APETag /home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:260:5
    #2 0x56359eabc365 in ReadMP3GainAPETag /home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:381:3
    #3 0x56359ea9a69b in main_impl /home/exp/src/mp3gain/mp3gain/mp3gain/mp3gain.c:1834:4
    #4 0x56359ea95431 in main /home/exp/src/mp3gain/mp3gain/mp3gain/mp3gain.c:2830:9
    #5 0x7f28b322a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #6 0x7f28b322a28a in __libc_start_main csu/../csu/libc-start.c:360:3
    #7 0x56359e9cc4b4 in _start (/home/exp/bin/asan_ubsan/mp3gain+0x4f4b4) (BuildId: 6adba16c3fc2a25561194f170abc8ab9f4e2b498)

0x6020000000b6 is located 0 bytes to the right of 6-byte region [0x6020000000b0,0x6020000000b6)
allocated by thread T0 here:
    #0 0x56359ea4fec2 in __interceptor_malloc (/home/exp/bin/asan_ubsan/mp3gain+0xd2ec2) (BuildId: 6adba16c3fc2a25561194f170abc8ab9f4e2b498)
    #1 0x56359eab868c in ReadMP3APETag /home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:216:24
    #2 0x56359eabc365 in ReadMP3GainAPETag /home/exp/src/mp3gain/mp3gain/mp3gain/apetag.c:381:3
    #3 0x56359ea9a69b in main_impl /home/exp/src/mp3gain/mp3gain/mp3gain/mp3gain.c:1834:4
    #4 0x56359ea95431 in main /home/exp/src/mp3gain/mp3gain/mp3gain/mp3gain.c:2830:9
    #5 0x7f28b322a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #6 0x7f28b322a28a in __libc_start_main csu/../csu/libc-start.c:360:3
    #7 0x56359e9cc4b4 in _start (/home/exp/bin/asan_ubsan/mp3gain+0x4f4b4) (BuildId: 6adba16c3fc2a25561194f170abc8ab9f4e2b498)

SUMMARY: AddressSanitizer: heap-buffer-overflow (/home/exp/bin/asan_ubsan/mp3gain+0xd219a) (BuildId: 6adba16c3fc2a25561194f170abc8ab9f4e2b498) in __asan_memcpy
Shadow bytes around the buggy address:
  0x0c047fff7fc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff8000: fa fa 00 fa fa fa fd fd fa fa fd fa fa fa fd fd
=>0x0c047fff8010: fa fa 00 07 fa fa[06]fa fa fa fa fa fa fa fa fa
  0x0c047fff8020: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==770181==ABORTING

[Kim Davies]

the poc.zip