Re: [Motion-user] 1080 % 16 = 8 and thus no 1080p

[Angel C. <mot...@gm...>]

I think moion uses modulo 16 expecting resolutions with apect radio 4/3 ,
your webcam uses 16/9 ,

have been talking with Joerg in IRC and probably there was a bug somehow
where we used 8, so

let us try to reproduce this bug before appy your suggestion.

Thanks !

Cheers,



On 22 December 2011 22:40, Angel Carpintero <mot...@gm...> wrote:

> Hi Jeroen ,
>
>  i don't remember why we added that check using 16 , makes sense to use 8
> instead.
>
> Let me review first and commit your change in trunk,
>
> Thanks !
>
> Cheers,
>
>
> On 22 December 2011 16:52, Jeroen Massar <je...@un...> wrote:
>
>> Hi,
>>
>> In video_common.c there is a check that checks if the image is a
>> multiple of 16. Thus 1080p won't work because of that check.
>>
>> I thus simply changed 16 into 8 and voila it works, nice MS Lifecam
>> Studio rocksolid with 1920x1080p ;)
>>
>> So my question then becomes if there is any other reason why this
>> limitation is there, a 8 byte one would be understandable, but no
>> reason, that I could find, why it would be 16.
>>
>> Greets,
>>  Jeroen
>>
>> --
>>
>> Index: video_common.c
>> ===================================================================
>> --- video_common.c      (revision 548)
>> +++ video_common.c      (working copy)
>> @@ -662,14 +662,14 @@
>>      * Motion requires that width and height is a multiple of 16 so we
>> check
>>      * for this first.
>>      */
>> -    if (conf->width % 16) {
>> -        MOTION_LOG(ERR, TYPE_VIDEO, NO_ERRNO, "%s: config image width
>> (%d) is not modulo 16",
>> +    if (conf->width % 8) {
>> +        MOTION_LOG(ERR, TYPE_VIDEO, NO_ERRNO, "%s: config image width
>> (%d) is not modulo 8",
>>                    conf->width);
>>         return -3;
>>     }
>>
>> -    if (conf->height % 16) {
>> -        MOTION_LOG(ERR, TYPE_VIDEO, NO_ERRNO, "%s: config image height
>> (%d) is not modulo 16",
>> +    if (conf->height % 8) {
>> +        MOTION_LOG(ERR, TYPE_VIDEO, NO_ERRNO, "%s: config image height
>> (%d) is not modulo 8",
>>                    conf->height);
>>         return -3;
>>     }
>>
>>
>> ------------------------------------------------------------------------------
>> Write once. Port to many.
>> Get the SDK and tools to simplify cross-platform app development. Create
>> new or port existing apps to sell to consumers worldwide. Explore the
>> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
>> http://p.sf.net/sfu/intel-appdev
>> _______________________________________________
>> Motion-user mailing list
>> Mot...@li...
>> https://lists.sourceforge.net/lists/listinfo/motion-user
>> http://www.lavrsen.dk/twiki/bin/view/Motion/WebHome
>>
>
>