Menu

#11 Give Java client+server methods a thorough review

0.9.6
open
nobody
None
2012-03-14
2012-03-05
Nigel Gay
No

Once the Java client+server have been ported to Java, all the Java methods need a thorough review, given they've pretty much been ported across as-is from their equivalent locations in the Delphi projects which may not be most appropriate.

Want to check for every method in every class:
1) That the method actually gets used somewhere (if not should it be removed);
2) That it is in the right project (if a method is in MoMIMECommon but only used on the server or client but not both then it should be moved into the appropriate project);
3) That every method has unit tests unless totally impossible or inappropriate (e.g. it would be nice if methods that send out messages could also be tested properly, including verifying that the correct messages get sent, but needs some thought how to do this, something along the lines of putting in an abstraction layer so that messages are marshalled to an outputstream which for the actual app running would be the actual TCP/IP socket but for the test methods would be a ByteArrayOutputStream whose contents could then be checked after running the method)

Discussion


Log in to post a comment.

MongoDB Logo MongoDB