#20 Program crash when deleting simultaneously atoms and their bonds

[Alexander Ploumistos]

If I select both oxygen atoms and the double bonds of the carbonyl groups of the attached molecule and hit delete, the program always segfaults. If I delete them one by one, no crash.

[Hendrik Vennekate]

Just a quick update: I applied some fixes, but it seems that the deletion mechanism per se might use an overhaul...
Fixes are on github for now, will upload as "latest" version to sourceforge shortly...

[Alexander Ploumistos]

Hi Hendrik,

I just tested your latest version with the same molecules and it doesn't crash. However, when I try to delete the oxygens and their double bonds, I end up with a water molecule on one side, while the other carbonyl remains unchanged.

[Hendrik Vennekate]

Hi Alexander,

sorry, I should have expressed myself more clearly: At the time, I only put it on github on the "lonePairsAndRadicals" branch (https://github.com/hvennekate/Molsketch/tree/lonePairsAndRadicals). I've just uploaded the latest snapshot to sourceforge, though, so you may try again now ;) .
The delete functionality did indeed have some quirks. I'm still not quite happy with the code as it is, but at least it should now do what it's supposed to do.

Best,

Hendrik

Edit: what is probably still missing is some garbage collection for empty molecules, as your example file also illustrates...

[Alexander Ploumistos]

Hello Hendrik,

I had taken a peek at your github repo, but I was waiting for the package to appear here and when I downloaded Molsketch-latest-src.tar.gz, sourceforge had it marked as changed in the last couple of days or something like that. The files inside the package were dated 1 October though.

Anyway, I just picked up the latest "latest" snapshot and took my time deleting atoms, bonds and parts of molecules. No crashes and no strange fragments left behind, so I'd say this is fixed.

[Hendrik Vennekate]

Ok, thanks, I'll close the ticket then.