#58 Edit window size not honored

closed-fixed
nobody
None
5
2004-07-21
2004-06-17
Neil Brooks
No

Setting the edit window size in UserPreferences to a size
other than the default is giving odd results.

Sometimes the window is displayed correctly until any
editing is done when it reverts to the default width.

Sometimes the new setting is ignored.

I need to reduce the width of the window to 65 as the
rightside bar themes (rightside and nirlo2) hide the edit
text. (which may be another bug)

This happens on my wiki running 1.2.2 and
http://moinmoin.wikiwikiweb.de/ The browser did not
seem to be a factor (IE6 and Firefox 0.9)

Discussion

  • Neil Brooks

    Neil Brooks - 2004-07-01

    Logged In: YES
    user_id=1065345

    The problem has been traced to PageEditor.py line 316.
    This is:
    self.request.write('<textarea name="savetext" rows="%d"
    cols="%d" style="width:100%%">%s</textarea>'

    The 'style=' is overriding the 'cols='. This implies that the cols
    setting doesn't work for left sided themes either.
    When 'style="width:100%%' is removed, the textarea shrinks
    to what you'd expect when you supply a 'cols=65'. It even
    shrinks with the default value of 80. This means that when
    this is fix is applied the usual editor window will shrink.

     
  • Neil Brooks

    Neil Brooks - 2004-07-01

    corrected PageEditor.py

     
  • Thomas Waldmann

    Thomas Waldmann - 2004-07-04

    Logged In: YES
    user_id=100649

    the question is if we rather should remove the cols setting
    from userpref (does it make any sense?) or if we remove the
    width=100% (who would want to use less?).

    rightside and nirlo2 seem to be fixed on
    moinmoin.wikiwikiweb.de, please check it there.

     
  • Thomas Waldmann

    Thomas Waldmann - 2004-07-21
    • status: open --> closed-fixed
     
  • Thomas Waldmann

    Thomas Waldmann - 2004-07-21

    Logged In: YES
    user_id=100649

    removed the columns setting in favour of width=100%

    will be in 1.2.3

     

Log in to post a comment.